Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENVINO CODE] Added Fill-in-the-middle(FIM) support #848

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

kumarijy
Copy link
Contributor

Adding FIM support through deepseek-coder-1.3b-instruct and changed model names at Frontend

@kumarijy kumarijy requested a review from a team as a code owner January 25, 2024 06:36
Copy link
Contributor

@apaniukov apaniukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must include a licence file to the HF model repository based on this.

The FIM feature description should be added to the README.md

"openvinoCode.startToken": {
"order": 7,
"type": "string",
"default": "<fim_prefix>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepseek-coder has a different FIM tokens format: "<|fim▁begin|>", check tokenizer.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to make a FIM feature a check box and to hardcode FIM tokens, as long as the model list is predefined.

@@ -4,22 +4,27 @@ enum ModelId {
CODE_T5_220M = 'Salesforce/codet5p-220m-py',
DECICODER_1B_OPENVINO_INT8 = 'chgk13/decicoder-1b-openvino-int8',
STABLECODE_COMPLETION_ALPHA_3B_4K_OPENVINO_INT8 = 'chgk13/stablecode-completion-alpha-3b-4k-openvino-int8',
//deepseek_coder = 'deepseek-ai/deepseek-coder-6.7b-instruct',
deepseek_coder_7b = 'kumarijy/deepseek-coder-1.3b-instruct_ov',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ALL_CAPS for consistency. It is also a 1_3B model, not a 7B.

@ilya-lavrenov ilya-lavrenov changed the title Added Fill-in-the-middle(FIM) support [OPENVINO CODE] Added Fill-in-the-middle(FIM) support Jan 30, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Jan 30, 2024
@apaniukov apaniukov merged commit a7293b4 into openvinotoolkit:master Feb 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants